relaycc / relay

relay.cc is a web3 directory of apps and profiles, plus the easiest way to message each of them.
https://www.relay.cc
5 stars 3 forks source link

Implementing a design system page to showcase each components #245

Open BrianS111 opened 1 year ago

BrianS111 commented 1 year ago

This will showcase all of the components in the lib/design file as described in https://github.com/relaycc/relay/issues/221

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
relay ❌ Failed (Inspect) Jan 23, 2023 at 0:11AM (UTC)
relay-develop ❌ Failed (Inspect) Jan 23, 2023 at 0:11AM (UTC)
BrianS111 commented 1 year ago

@killthebuddh4 So if a file is called 'Button' for example in figma, and the file in the Relay Code is ButtonView.tsx, do you want me to change the file in The Relay Code section to 'Button.tsx'? Or will that cause dev confusion

BrianS111 commented 1 year ago

Notes on AboutIcon.tsx: File could benefit by switching hex colors over to theme variables

BrianS111 commented 1 year ago

Notes on AlertCircle.tsx: File can benefit from switching hex colors to Theme Variables

BrianS111 commented 1 year ago

Notes on ArrowUpCircle.tsx: The component uses Gray/600 and the figma file has it listed at Gray/400 which are slightly two different hex codes

BrianS111 commented 1 year ago

Badge.tsx needs to include props for the colored version and also a prop to display the dot to the left of the text.

Image 1-19-23 at 2 34 PM

It also needs functionality for truncation in the case of long text

Image 1-19-23 at 2 35 PM

BrianS111 commented 1 year ago

ChatIcon.tsx can benefit from using project variables instead of hex codes

BrianS111 commented 1 year ago

Checkbox.tsx is missing the warning / disabled state shown in the two icons below. If the warning state is in a component I get to down the line, they should probably me merged in to one component like shown in Figma. The component is also using hex codes instead of project variables. Image 1-19-23 at 2 58 PM

BrianS111 commented 1 year ago

CloseIcon.tsx can benefit from using project variables instead of hex codes

BrianS111 commented 1 year ago

Compose.tsx is missing its loading state / prop which is the icon on the bottom of this image. It is also using hex codes instead of project variables

Image 1-19-23 at 3 16 PM

BrianS111 commented 1 year ago

Copy.tsx can benefit from using project variables instead of hex codes

BrianS111 commented 1 year ago

Dropdownicon.tsx can benefit from using project variables instead of hex codes

BrianS111 commented 1 year ago

Edit.tsx is missing its Loading prop / loading functionality as shown in Figma. It is also using hex colors instead of project variables

Image 1-20-23 at 8 07 AM

BrianS111 commented 1 year ago

ENSID.tsx has a hard coded with, which can be fine if it ends up working with the receiver dimensions, but most likely should use a full width and rely on what its placed in to determine the actual with via padding.

On the Profile screen = false view, while the ETH Network aligns with the bottom elements, It isn't aligned according to the figma file which has it placed higher to center align with the elements to it's left as shown in the screenshot below

Image 1-20-23 at 8 34 AM

killthebuddh4 commented 1 year ago

@killthebuddh4 So if a file is called 'Button' for example in figma, and the file in the Relay Code is ButtonView.tsx, do you want me to change the file in The Relay Code section to 'Button.tsx'? Or will that cause dev confusion

Don't change any of the file names for now, just take notes.

BrianS111 commented 1 year ago

@killthebuddh4 So if a file is called 'Button' for example in figma, and the file in the Relay Code is ButtonView.tsx, do you want me to change the file in The Relay Code section to 'Button.tsx'? Or will that cause dev confusion

Don't change any of the file names for now, just take notes.

Yea, thats what I figured. to not mess up imports and such

BrianS111 commented 1 year ago

LinkIcon.tsx and Logout.tsx are missing a loading prop and component as shown in Figma

Image 1-20-23 at 9 52 AM Image 1-20-23 at 2 09 PM

BrianS111 commented 1 year ago

Msgbox.tsx is missing loading prop / loading functionality

Image 1-20-23 at 2 50 PM

BrianS111 commented 1 year ago

Still a few more components to go, build is broken currently because props on PinIcon.tsx