Messages and request bugs

Aaron-EE commented 1 year ago

Fixes the messages and requests not showing up. However it seems not all the received messages show up in the direct message screen, and on the message screen ChatPreview, its not the last message in the conversation that shows up. This might be an issue specific to the conversation I tested with however. We should look into it/discuss it in discord.

Closes #339

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
dev-relay	✅ Ready (Inspect)	Visit Preview	Jan 31, 2023 at 0:12AM (UTC)
relay	✅ Ready (Inspect)	Visit Preview	Jan 31, 2023 at 0:12AM (UTC)

matejcsok-ee commented 1 year ago

I found that during debugging we changed the useDirectMessages hook's params

 // from this
  const { messages, sendMessage } = useDirectMessage({
    clientAddress: address as EthAddress,
    conversation: { peerAddress },
  });

 //to this
  const { messages, sendMessage } = useDirectMessage({
    clientAddress: address as EthAddress,
    conversation,
  });

and we sent messages to each other, so there is a case when conversionID is empty string, and another when it is undefined, so those are 2 different conversations so I think everything is fine, just the initial

    write({ content: JSON.stringify({}) });

was missing, when the relay.cc/requests conversation doesn't exist yet

but on xmtp production chat I see both of those conversations in one conversation, I assume they fetch both of them and merge them together? I am a bit still confused, but if we don't change the code while sending messages, it will be fine

relaycc / relay

Messages and request bugs #340