relaycorp / awala-endpoint-android

High-level library for Android apps implementing Awala endpoints
Apache License 2.0
2 stars 1 forks source link

feat: Re-issue/send PDAs when first-party endpoint certificates are renewed #212

Closed gnarea closed 2 years ago

gnarea commented 2 years ago

Fixes #185. It's also worth highlighting the following:

Review notes

Of things that I'm likely to have got wrong here, I'd rank highly the use of SharedPreferences and coroutines (esp. where I have to specify a context explicitly), so please pay special attention to those.

gnarea commented 2 years ago

Hmm, one thing I just realised is that FirstPartyEndpoint.authorizeIndefinitely() and FirstPartyEndpoint.issueAuthorization() must actually return ByteArrays -- otherwise we'd be leaking the Awala lib to the apps using this lib.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: