search

relaycorp / awala-endpoint-internet

Middleware for server-side apps to communicate over Awala without implementing any of the networking or cryptography from the protocol suite.
https://docs.relaycorp.tech/awala-endpoint-internet/
GNU Affero General Public License v3.0
0 stars 0 forks source link

feat: Implement storing PDA #32

Closed levansuper closed 1 year ago

levansuper commented 1 year ago

closes: #15

I had to decompose the parcel route handler since it was becoming too large and we were getting lint error. Made smaller functions inside the same file. Should we move them to the business logic file?

gnarea commented 1 year ago

Sorry, I forgot to respond to this:

I had to decompose the parcel route handler since it was becoming too large and we were getting lint error. Made smaller functions inside the same file. Should we move them to the business logic file?

The call to InternetEndpoint.savePrivateEndpointChannel() is the only business logic I see in that route, and it's all already encapsulated in a function.

More generally though, the actual business logic in this app should live under InternetEndpoint or its channel class; as a reminder, the channel is the "link" between the Internet endpoint and its peer. And in this particular PR, I don't see anything else that we'd want to move to either of those two classes.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: