Closed gnarea closed 2 years ago
FYI -- I've just moved this item to the top of the maintenance board, since this is making it so hard to maintain this app.
@gnarea sorry, holiday and another project, I will try to get to this today or tomorrow!
No worries @Filmaluco! 👍🏾
@Filmaluco, I just realised that #177 didn't fix the third test in this issue and it's failing again in other PRs, so I'm reopening this issue.
It seems like that PR only addressed two of the three issues.
:tada: This issue has been resolved in version 1.2.0 :tada:
The release is available on:
v1.2.0
Your semantic-release bot :package::rocket:
@gnarea the 3rd issue was the one with certificates, related to the expiration date. From what we talked about I was under the impression that you said you knew about the issue and had solved it. Should I push the updated certificate...?
@Filmaluco, I'm pretty sure the expired certificate has nothing to do with that. If it were failing due to the expired certificate, it wouldn't be a flaky test because it'd fail 100% of the time.
From the stacktrace above, I'd imagine it's something to do with the UI. I'm attaching the full logs related to the broken test in case that's relevant, but there's a lot of noise there. flaky-test-log.txt
@gnarea oh, since I was reproducing all the time I did not notice it was also a flaky one. I will take a closer look
Yeah, the 3rd flaky test is far less frequent than the other two. Also, I've just noticed it seems to only happen on the Pixel 2, API 30.
@gnarea seems that 3rd test is not that flaky and it doesn't even have the @AllowFlaky(attempts = 3)
annotation. Probably if we add it, it's going to be all green.
By the way, the current test runs seem to have a gcloud account issue: Service account is required to authorize gcloud to access the Cloud Platform.
@gnarea seems that 3rd test is not that flaky and it doesn't even have the @AllowFlaky(attempts = 3) annotation. Probably if we add it, it's going to be all green.
Indeed, it doesn't break often. I wasn't sure if @AllowFlaky
would apply here too but it sounds like it's worth trying that.
By the way, the current test runs seem to have a gcloud account issue: Service account is required to authorize gcloud to access the Cloud Platform.
That's a bug in GitHub Actions :( Sometimes it fails to pass secrets to actions, or passes an empty string. The only workaround is to retry the job :/
:tada: This issue has been resolved in version 1.2.1 :tada:
The release is available on:
v1.2.1
Your semantic-release bot :package::rocket:
I've found 3 tests that often break:
Test 1:
tech.relaycorp.ping.ui.ping.SendPingActivityTest:picksDefaultPeer
See: https://github.com/relaycorp/awala-ping-android/pull/165#issuecomment-953890270
Test 2:
tech.relaycorp.ping.ui.ping.PingActivityTest:displaysPingWithPong
https://console.firebase.google.com/u/0/project/awala-ping-android/testlab/histories/bh.6e5c9f23e2ef2570/matrices/5338090043455903581/executions/bs.8fe1913caddc3279/testcases/9/logs
Test 3:
tech.relaycorp.ping.ui.peers.AddPublicPeerActivityTest:addPublicPeerSuccessfully
https://console.firebase.google.com/u/0/project/awala-ping-android/testlab/histories/bh.6e5c9f23e2ef2570/matrices/5338090043455903581/executions/bs.8fe1913caddc3279/testcases/2/test-cases