search

relaycorp / awala-ping-android

Android app for the Awala Ping Service
GNU General Public License v3.0
0 stars 0 forks source link

feat: Ability to copy Parcel Id from Details #269

Closed Filmaluco closed 1 year ago

Filmaluco commented 1 year ago

Screenshot 2023-01-16 at 19 29 16

gnarea commented 1 year ago

BTW, I believe you want to use master as the target branch. I didn't want to change it myself because the current target isn't in sync with master (same code, different commits).

Filmaluco commented 1 year ago

Based on the screenshot you shared, this PR seems to introduce changes to the horizontal lines that separate fields. Some lines are dark grey, other light grey, and some fields are not separated by any lines.

This is what I see on my phone right now:

Screenshot_20230117-113350

I think the original design should be preserved.

no changes, the reason it seems like that its because its a XML preview :) I did against the 33 branch because we never merged it... we can now merge it, and it should be merge first. Then this one will automatically go to master

gnarea commented 1 year ago

@Filmaluco, makes sense. #267 is now merged. I thought we were waiting for you to fix something in the instrumentation tests because they were failing last time I looked.

gnarea commented 1 year ago

BTW @Filmaluco, did you test this? Asking because of the Android Studio screenshot, so not clear if you tested it on an actual device with the gateway.

Filmaluco commented 1 year ago

@gnarea I tested with an actual device, did not do the test with gateway, since I was waiting on the feedback about GCP issue. will make a test on Monday at the office, at home, I only have 1 android to test.

gnarea commented 1 year ago

I tested with an actual device, did not do the test with gateway since I was waiting on the feedback about GCP issue.

Keep in mind that the GCP issue only affects the the Courier app, not any other app or library.

will make a test on Monday at the office, at home, I only have 1 android to test.

👍🏾

Filmaluco commented 1 year ago

I tested with an actual device, did not do the test with gateway since I was waiting on the feedback about GCP issue.

Keep in mind that the GCP issue only affects the the Courier app, not any other app or library.

will make a test on Monday at the office, at home, I only have 1 android to test.

👍🏾

in that case, its tested :) you can merge.

Filmaluco commented 1 year ago

@gnarea just finished testing this version of ping against gateway from https://github.com/relaycorp/relaynet-gateway-android/pull/675.

image

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: