search

relaycorp / awala-ping-android

Android app for the Awala Ping Service
GNU General Public License v3.0
0 stars 0 forks source link

chore(deps): Upgrade coroutines to v1.7 #279

Closed gnarea closed 1 year ago

gnarea commented 1 year ago

The main change is converting BroadcastChannel.asFlow() to MutableSharedFlow.asSharedFlow(), which I'm not entirely sure I'm doing correctly (it feels odd to have to call asSharedFlow() on a subclass of SharedFlow).

sdsantos commented 1 year ago

The main change is converting BroadcastChannel.asFlow() to MutableSharedFlow.asSharedFlow(), which I'm not entirely sure I'm doing correctly (it feels odd to have to call asSharedFlow() on a subclass of SharedFlow).

Yup, you did the correct change, and have MutableSharedFlow with the right arguments.

With MutableStateFlow we call asStateFlow to get an immutable StateFlow, and with MutableSharedFlow we call asSharedFlow to get an immutable SharedFlow.

gnarea commented 1 year ago

Obrigado! 🙏🏾

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: