search

relayjs / relay-devtools

Relay Development Tools
MIT License
147 stars 30 forks source link

Silences console error spam when object can't be cloned #26

Closed jaycenhorton closed 5 years ago

jaycenhorton commented 5 years ago

This PR is mainly just an "additional information" PR for #20

There has got to be a better solution to this, but this is how I am silencing errors related to #20

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

programurr commented 5 years ago

@jaycenhorton It seems that there were a lot of console logs leftover from development. I went ahead and cleaned those up, I'm going to verify real quick if removing those solves the problem before we adding your try catch.

jaycenhorton commented 5 years ago

That would be fantastic! Let me know when there's a new version I should try to build to verify from my end

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

sibelius commented 5 years ago

this is happening to me as well

kassens commented 5 years ago

Sorry we've been neglecting the devtools for too long! I just merged a branch for a new attempt at the devtools and closing this old Issue. Please us report issues!