JosephKav
commented
1 year ago Oh cool, didn't know about this 'conditional requests' feature. I'll get straight on this! Thanks for letting me know about it, it will definitely help with the rate-limiting!
I'll get it storing the ETag each time it queries and use it if it has one. I'll also store the filtered release tags until the tag at the top (most-recent) matches the require filters as
- two tags could be released in the Argus check interval but only one with the docker images out, so the other would be missed but may be the newer release
- a new version may come out but not have the docker images released yet. So the ETag isn't going to change, but we need to keep checking the tag until the docker image is out
Is your feature request related to a problem? Please describe. For user who do not want to use a github account, or are tracking many projects, will more or less likely run into the github api rate-limiting, currently at 60 requests/hour or 5000 request/hour/user. Especially for unauthenticated requests, this limit will be hit very quickly.
Describe the solution you'd like Github provides a mechanism to reduce the api limit hit-rate, by using conditional requests. Argus would query github at first time as normal, store the
Etagfor the service of type github. At the next request for the same service, the header If-None-Match should be use with the previous etag-value. If the resource changed (different etag), the server responds per normal with status code 200, if nothing changed it responds with304 Not Modified. If nothing was modified, the remaining api limit should not be reduced. In that case argus could just abort with anothing changederror or similar, or return the response of the provided etag, in case it was cached too (though just "aborting" would be better in my opinion, saves resources)Example headers from using a command like
curl -v https://api.github.com/repos/release-argus/argus/releasesExample headers from using a command like
curl -v -H 'If-None-Match: W/"1ce3fe5cd3749c19b72b12dd7c1f2308bd530d49ef555a633eb0ee0b622d07ca"' https://api.github.com/repos/release-argus/argus/releases(no response body)Describe alternatives you've considered The only alternative is to use a github account and hope.
Additional context This would be a huge saver for all users, as argus would most likely never hit the api rate limit again, at least in github (just being optimistic).