release-argus / Argus

Argus is a lightweight monitor to notify of new software releases via Gotify/Slack/other messages and/or WebHooks.
https://release-argus.io
Apache License 2.0
290 stars 11 forks source link

bug: SMTP E-Mail "fromname: XXX" not working #352

Open tobi-wld opened 7 months ago

tobi-wld commented 7 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Set "fromname: XXX" in config.yml
  2. Start Release-Argus
  3. Wait until new Release
  4. See E-Mail Sender Name not matching configured From-Name

Expected behavior Seeing the properly set From-Name from the config.yml. This does work with other Services so it cannot be an E-Mail-Client or E-Mail-Server Problem. I have tried to write the String after "fromname:" within Quotation Marks but this has not resolved the Problem.

Screenshots Screenshot 2024-01-19 002359 Screenshot 2024-01-19 002212

Desktop:

JosephKav commented 7 months ago

Ah, thanks for reporting! Looked into this and it seems to be an issue with Shoutrrr ignoring the params var. Have made a PR to try and address this