search

release-depot / git_wrapper

A python based wrapper around GitPython
MIT License
4 stars 8 forks source link

Fix rebasing on branch issue #28

Closed jpichon closed 6 years ago

jpichon commented 6 years ago

Rebase currently creates a 'floating' commit as a result, as opposed to rebasing the branch itself. This fixes it so that the branch gets properly updated with the rebase result after running the command.

jpichon commented 6 years ago

I don't think there is a reasonable unit test for this, with a mocked Repo object. It'll be a nice one for integration testing with a real git repo though.

The patch includes some additional cleanups but L49 is the only change necessary for fixing the bug.