search

release-depot / git_wrapper

A python based wrapper around GitPython
MIT License
4 stars 8 forks source link

Fix branch names in github action #79

Closed jpichon closed 3 years ago

jpichon commented 3 years ago

Nice to see the github checks running! Although I'm not sure why Travis still shows in here, the configuration shouldn't be on master anymore either. And it says "Required"? I wonder if it's because it's in the webhooks settings? I'm not seeing anything else obvious in the settings.

Interestingly, although the github action tests have all passed, the Mergify configuration doesn't seem to be picking up on them: "status-success=Run tests" still shows as unchecked. So I will use this PR to also adjust the Mergify configuration this round, since the short name unfortunately doesn't seem to work.

jpichon commented 3 years ago

Ah, I found the setting, leaving it here in case the problem comes up in a different project since it wasn't obvious to me: when going to the branch settings, there's a list of "protected" branches. I thought that meant "can't delete" but actually when going to edit it there are a bunch of rules and the travis checkbox was checked under this.