search

release-depot / git_wrapper

A python based wrapper around GitPython
MIT License
4 stars 8 forks source link

Fix "Upload Package to Pipy" workflow #88

Closed jpichon closed 3 years ago

jpichon commented 3 years ago

The "Upload package to Pypi" workflow doesn't work.

The job fails with the following traceback:

 python setup.py sdist bdist_wheel
  twine upload dist/*
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.9.6/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.6/x64/lib
    TWINE_USERNAME: ***
    TWINE_PASSWORD: ***
/opt/hostedtoolcache/Python/3.9.6/x64/lib/python3.9/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'author-email' will not be supported in future versions. Please use the underscore name 'author_email' instead
  warnings.warn(
/opt/hostedtoolcache/Python/3.9.6/x64/lib/python3.9/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
  warnings.warn(
/opt/hostedtoolcache/Python/3.9.6/x64/lib/python3.9/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'home-page' will not be supported in future versions. Please use the underscore name 'home_page' instead
  warnings.warn(
WARNING: The wheel package is not available.
/opt/hostedtoolcache/Python/3.9.6/x64/lib/python3.9/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'author-email' will not be supported in future versions. Please use the underscore name 'author_email' instead
  warnings.warn(
/opt/hostedtoolcache/Python/3.9.6/x64/lib/python3.9/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
  warnings.warn(
/opt/hostedtoolcache/Python/3.9.6/x64/lib/python3.9/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'home-page' will not be supported in future versions. Please use the underscore name 'home_page' instead
  warnings.warn(
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

error: invalid command 'bdist_wheel'
Error: Process completed with exit code 1.

Note: We'll also need to update step 2 in the new release the README (https://github.com/release-depot/git_wrapper#pushing-a-new-release): right now, pushing a tag is not sufficient. The "create new release" button needs to be clicked on github as well.

Additionally, when the release was created, 3 publish jobs immediately started running in parallel: https://github.com/release-depot/git_wrapper/actions?query=event%3Arelease . We'll likely want to avoid that as well.

jguiditta commented 3 years ago

ok, so the actual error is caused becuase 'wheel' is not listed as a dependency, we must have had it locally installed previously. Rather than fixing that separately, I think I would prefer to do the planned realignment of build process with flask-container-scaffold, and fold in a test for this fix as part of that. I will look into the release part next and reply to that separately, as it seems different than what I have seen on flask-container-scaffold (it created the release when I pushed the tag not that long ago, see here). Not sure yet on the multiple triggers of the job either, but I'll follow up when I have an idea why that happened.