Change how we generate version for test pypi builds.

release-depot / git_wrapper

A python based wrapper around GitPython

MIT License

4 stars 8 forks source link

Change how we generate version for test pypi builds. #93

Closed jguiditta closed 3 years ago

jguiditta commented 3 years ago

The tooling by default appends '+{hash}' to non-tagged builds, which is not compliant with the format required by pypi. This patch chops off the '+' bit, so you get a version like '0.2.9.dev5' where 'dev5' is the number of commits from the last tag. Provided github action puts the env var where the python tooling expects it, this should solve the issue for test deploys (production is unchanged).

Signed-off-by: Jason Guiditta jguiditt@redhat.com

jguiditta commented 3 years ago

since the new job wont run until merge, here are the results from pushing commit to my fork: https://github.com/jguiditta/git_wrapper/runs/3507023658?check_suite_focus=true Note that the fail at 'push to test pypi' step is expected because I do not have an api token set up on my repo.