search

release-drafter / release-drafter

Drafts your next release notes as pull requests are merged into master.
https://github.com/marketplace/actions/release-drafter
ISC License
3.35k stars 326 forks source link

Resolve tags in target commitish #1395

Open nicksloan opened 3 months ago

nicksloan commented 3 months ago

Here an error is returned if targetCommitish is a tag. I understand that GitHub doesn’t allow tags (though not why), but I don’t understand why release-drafter can’t just resolve the commit that a tag points to and use that.

We have a nightly tag that is updated nightly, and we trigger release-drafter on pushes to that tag. When we do, the release ends up using main as a target.

At the very least the docs could be improved.

nicksloan commented 3 months ago

I’m up for working on a PR if I can get some guidance on approach.