Small improvements of upload.cgi script

release-engineering / dist-git

DistGit provides home for linux distribution packages.

Other

123 stars 38 forks source link

Small improvements of upload.cgi script #32

Closed FrostyX closed 4 years ago

FrostyX commented 4 years ago

I made a few small changes in upload.cgi script. They are basically just refactoring by moving pieces of code from main into their own separate functions.

There is an added value though. A different config file can be specified via DISTGIT_CONFIG environment variable (which is useful e.g. for tests) and the upload.cgi can be executed even when python fedmsg package is not installed (which is valuable for non-Fedora instances).

clime commented 4 years ago

Thank you very much for your work. If you can fix that one comment regarding md5, that would be great. Otherwise, I'll merge and fix it by a separate commit.

clime commented 4 years ago

Thanks again!