release-engineering / pom-manipulation-ext

A more generic framework-style extension for preprocessing Maven pom.xml files before the build runs (from within Maven itself)
https://release-engineering.github.io/pom-manipulation-ext/
Apache License 2.0
52 stars 74 forks source link

Clarify docs for destination of dependencyInjection GAVs #994

Closed ASzc closed 1 year ago

ASzc commented 1 year ago

The way the documentation is worded, it makes it sound like -DdependencyInjection adds a real dependency entry to the POMs. In fact it adds a dependencyManagement entry, as seen in the code here:

https://github.com/release-engineering/pom-manipulation-ext/blob/main/core/src/main/java/org/commonjava/maven/ext/core/impl/DependencyInjectionManipulator.java#L95

rnc commented 1 year ago

Thanks!