search

release-engineering / pom-version-manipulator

Align versions in Maven POMs with those found in a Bill-of-Materials POM
Other
11 stars 9 forks source link

Don't remove plugin versions which are not defined in plugin management bom #93

Closed pgier closed 11 years ago

pgier commented 11 years ago

Currently the plugin management part of v-man removes all plugin versions and provides a warning if these plugin versions are not defined in the plugin management bom. It would be better if v-man only removed plugin versions which are defined in the bom.

jdcasey commented 11 years ago

This is a feature of strict mode. If you're not using the BOM modifications, you might consider using strict mode instead of disabling it.

If you can't use strict mode, then we'll need to talk about breaking the strict flag into sub-flags for each modifier, I guess.

pgier commented 11 years ago

So if we turn on strict mode, then only matching plugin versions would be removed? What other effects does strict mode have? Would it still allow us to update the current project version, and remove from the pom?

jdcasey commented 11 years ago

I think the only other thing (besides BOM adjustment) that's affected is whether the parent version is adjusted without having the parent listed in the BOM. With strict mode off, it will indiscriminately guess at the parent version if it's not listed in the BOM (IIRC), but with strict mode on, it won't touch that version unless it's in the BOM.

I believe the changes to the current project's version are unaffected by that flag.

pgier commented 11 years ago

Ok, sounds like we should start using that, thanks!