release-engineering / pubtools-pulplib

A Pulp library for publishing tools
GNU General Public License v3.0
2 stars 24 forks source link

Limit kw_only usage to attrs 18.2 or newer #195

Closed MichalHaluza closed 1 year ago

MichalHaluza commented 1 year ago

Apart from python2, the kw_only keyword argument for attr.s() throws TypeError: attrs() got an unexpected keyword argument 'kw_only' also on python3 installations using version of attrs module older than 18.2. RHEL-8 ships attrs in version 17.4, hence the argument needs to be excluded there as well.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (0cdd514) compared to base (caa383a). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #195 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 48 48 Lines 2968 2969 +1 ========================================= + Hits 2968 2969 +1 ``` | [Impacted Files](https://codecov.io/gh/release-engineering/pubtools-pulplib/pull/195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering) | Coverage Δ | | |---|---|---| | [pubtools/pulplib/\_impl/compat\_attr.py](https://codecov.io/gh/release-engineering/pubtools-pulplib/pull/195/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-cHVidG9vbHMvcHVscGxpYi9faW1wbC9jb21wYXRfYXR0ci5weQ==) | `100.00% <ø> (ø)` | | | [pubtools/pulplib/\_impl/log.py](https://codecov.io/gh/release-engineering/pubtools-pulplib/pull/195/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-cHVidG9vbHMvcHVscGxpYi9faW1wbC9sb2cucHk=) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.