search

release-engineering / ubi-population-tool

A tool for populating UBI repositories.
GNU General Public License v3.0
3 stars 14 forks source link

Added GitHub Actions #156

Closed daminijain23 closed 3 years ago

daminijain23 commented 3 years ago

Added - release.yml and tox-test.yml Removed - .travis.yml

https://projects.engineering.redhat.com/browse/RHELDST-7276

cd-red-bot commented 3 years ago

Can one of the admins verify this patch?

rbikar commented 3 years ago

@daminijain23 Looks good to me, but can you please check whether it's possible also to trigger JenkinsCI by GH Actions? Currently it's done by manually adding comment to PR like "run tests" or similar.

rbikar commented 3 years ago

@daminijain23 I added one comment about installation of some specific package, can you have a look? Otherwise this looks OK, and I would rather merge it, so we can test it properly and later add support for JENKINS CI trigger, if possible. Also in one newer PR https://github.com/release-engineering/ubi-population-tool/pull/162, it looks that Travis is not part of checks for some reason :(

rbikar commented 3 years ago

@daminijain23 I just wonder, why travis.yml is back. This file shouldn't be needed now. Or am I missing something?

daminijain23 commented 3 years ago

@rbikar krb5 package have been removed from coverage flow as it wasn't required. .travis.yml was added back as backup in case github actions errors out and until all issues get resolved

rbikar commented 3 years ago

O

@rbikar krb5 package have been removed from coverage flow as it wasn't required. .travis.yml was added back as backup in case github actions errors out and until all issues get resolved

OK, sounds good, I'll merge this now and let's see how it works :)