search

release-engineering / ubi-population-tool

A tool for populating UBI repositories.
GNU General Public License v3.0
3 stars 14 forks source link

Poor logging #18

Open alexandrevicenzi opened 5 years ago

alexandrevicenzi commented 5 years ago

ubipop should produce more verbose logging if possible a way to set -v -vv -vvvv to define how much log is produced.

I've been running ubipop with default configuration file from ubi-config and this was the output produced:

2019-03-25 11:35:48 +0000 [INFO    ] Getting input repos for input content sets:
    rhel-7-server-rpms
    rhel-7-server-source-rpms
    rhel-7-server-debug-rpms
2019-03-25 11:35:48 +0000 [INFO    ] Getting output repos for output content sets:
    ubi-7-server-rpms
    ubi-7-server-source-rpms
    ubi-7-server-debug-rpms
2019-03-25 11:40:16 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7Server__x86_64 in yum_distributor
2019-03-25 11:40:16 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7Server__x86_64 in yum_distributor
2019-03-25 11:40:16 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7Server__x86_64 in yum_distributor
2019-03-25 11:40:16 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7Server__x86_64 in cdn_distributor
2019-03-25 11:40:16 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7Server__x86_64 in cdn_distributor
2019-03-25 11:40:16 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7Server__x86_64 in cdn_distributor
2019-03-25 11:41:03 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7_DOT_0__x86_64 in yum_distributor
2019-03-25 11:41:03 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7_DOT_0__x86_64 in yum_distributor
2019-03-25 11:41:03 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7_DOT_0__x86_64 in yum_distributor
2019-03-25 11:41:43 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7_DOT_1__x86_64 in yum_distributor
2019-03-25 11:41:43 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7_DOT_1__x86_64 in yum_distributor
2019-03-25 11:41:43 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7_DOT_1__x86_64 in yum_distributor
2019-03-25 11:42:19 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7_DOT_2__x86_64 in yum_distributor
2019-03-25 11:42:19 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7_DOT_2__x86_64 in yum_distributor
2019-03-25 11:42:19 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7_DOT_2__x86_64 in yum_distributor
2019-03-25 11:42:54 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7_DOT_3__x86_64 in yum_distributor
2019-03-25 11:42:54 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7_DOT_3__x86_64 in yum_distributor
2019-03-25 11:42:54 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7_DOT_3__x86_64 in yum_distributor
2019-03-25 11:43:30 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7_DOT_4__x86_64 in yum_distributor
2019-03-25 11:43:30 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7_DOT_4__x86_64 in yum_distributor
2019-03-25 11:43:30 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7_DOT_4__x86_64 in yum_distributor
2019-03-25 11:44:04 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7_DOT_5__x86_64 in yum_distributor
2019-03-25 11:44:04 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7_DOT_5__x86_64 in yum_distributor
2019-03-25 11:44:04 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7_DOT_5__x86_64 in yum_distributor
2019-03-25 11:44:40 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7_DOT_6__x86_64 in yum_distributor
2019-03-25 11:44:40 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7_DOT_6__x86_64 in yum_distributor
2019-03-25 11:44:40 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7_DOT_6__x86_64 in yum_distributor
2019-03-25 11:45:16 +0000 [DEBUG   ] Publishing ubi-7-server-rpms__7_DOT_7__x86_64 in yum_distributor
2019-03-25 11:45:16 +0000 [DEBUG   ] Publishing ubi-7-server-debug-rpms__7_DOT_7__x86_64 in yum_distributor
2019-03-25 11:45:16 +0000 [DEBUG   ] Publishing ubi-7-server-source-rpms__7_DOT_7__x86_64 in yum_distributor

No info about what packages are on the repo, no info about what packages were in the YAML file, no info about what packages are in the blacklist, with this output I have no idea what was done if something was really done at all.

If I run with --dry-run it actually says what packages are going to be associated and which ones are going to be unassociated.

rbikar commented 5 years ago

@alexandrevicenzi Partially fixed in #23 Added logging for un/associate actions.

rbikar commented 5 years ago

@alexandrevicenzi I didn't count with logging of ubi config whitelist or blacklist. But it's not a problem to add it there. But in config file, there are only names of packages or/and arch so not sure if it's really useful.

alexandrevicenzi commented 5 years ago

@rbikar verbosity is good, does not need to include everything, but I think the packages that are going to be published/unpublished/blacklisted is a good way to know what is being done.