search

release-engineering / ubi-population-tool

A tool for populating UBI repositories.
GNU General Public License v3.0
3 stars 14 forks source link

Improve the log of associate and unassociate [RHELDST-9945] #197

Closed LinglingXiang closed 1 year ago

LinglingXiang commented 1 year ago

1.add method to make log for associate and unassociate more readable 2.add the unit test for testing the unassocate module default log 3.add the unit test for testing the associate package log

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.25% // Head: 97.27% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (af2765e) compared to base (72a0f4b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #197 +/- ## ========================================== + Coverage 97.25% 97.27% +0.02% ========================================== Files 7 7 Lines 1055 1066 +11 ========================================== + Hits 1026 1037 +11 Misses 29 29 ``` | [Impacted Files](https://codecov.io/gh/release-engineering/ubi-population-tool/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering) | Coverage Δ | | |---|---|---| | [ubipop/\_pulp\_client.py](https://codecov.io/gh/release-engineering/ubi-population-tool/pull/197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL19wdWxwX2NsaWVudC5weQ==) | `96.96% <100.00%> (+0.27%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rbikar commented 1 year ago
  1. Please rewrite PR and commit description so it fits into the limit.
  2. Also a bit more precise commit message wouldn't harm.
  3. Can you also add some simple test or update the current ones? Thx.
rbikar commented 1 year ago

@LinglingXiang Changes look OK, please rebase on current master to fix the py27 tests. Thx.

And please fix commit and PR name, it's too long. And add new commit message to PR descritpion.