release-engineering / ubi-population-tool

A tool for populating UBI repositories.
GNU General Public License v3.0
3 stars 14 forks source link

Remove Legacy code in ubipop [RHELDST-13337] #199

Closed jihupdc closed 1 year ago

jihupdc commented 1 year ago

1.Legacy code in ubipop is removed. 2.ubi-manifest is the only source of expected content for ubipop.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.27% // Head: 96.58% // Decreases project coverage by -0.69% :warning:

Coverage data is based on head (f48922a) compared to base (2bce7d3). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head f48922a differs from pull request most recent head 1a6c961. Consider uploading reports for the commit 1a6c961 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #199 +/- ## ========================================== - Coverage 97.27% 96.58% -0.70% ========================================== Files 7 7 Lines 1066 850 -216 ========================================== - Hits 1037 821 -216 Misses 29 29 ``` | [Impacted Files](https://codecov.io/gh/release-engineering/ubi-population-tool/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering) | Coverage Δ | | |---|---|---| | [ubipop/\_matcher.py](https://codecov.io/gh/release-engineering/ubi-population-tool/pull/199/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL19tYXRjaGVyLnB5) | `98.76% <ø> (-0.84%)` | :arrow_down: | | [ubipop/\_utils.py](https://codecov.io/gh/release-engineering/ubi-population-tool/pull/199/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL191dGlscy5weQ==) | `100.00% <ø> (+1.08%)` | :arrow_up: | | [ubipop/cli.py](https://codecov.io/gh/release-engineering/ubi-population-tool/pull/199/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL2NsaS5weQ==) | `95.91% <ø> (ø)` | | | [ubipop/\_\_init\_\_.py](https://codecov.io/gh/release-engineering/ubi-population-tool/pull/199/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL19faW5pdF9fLnB5) | `94.14% <100.00%> (-0.46%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rbikar commented 1 year ago

Please check coverage report whether the reported problems are new or if they were not covered previously as well. Also rebase on current on master, you are currently reverting some change already merged in master.

rbikar commented 1 year ago

Please see detailed codecov report https://app.codecov.io/gh/release-engineering/ubi-population-tool/pull/199 and please fix parts of code that are newly not covered by tests.

rbikar commented 1 year ago

@jihupdc Please rebase on master so the py27 tests can pass.

rbikar commented 1 year ago

@jihupdc I think this PR needs another rebase on master to fix the failing test or maybe another fix (ref. https://github.com/release-engineering/ubi-population-tool/pull/198/files )

rbikar commented 1 year ago

run tests

rbikar commented 1 year ago

jenkins CI seems to be still broken