release-engineering / ubi-population-tool

A tool for populating UBI repositories.
GNU General Public License v3.0
3 stars 14 forks source link

Fix scheme handling and verify option for pulp clients #212

Closed rbikar closed 1 year ago

rbikar commented 1 year ago

In the recent refactoring of pulp clients creation there were introduced some inconsistent handling of scheme and verify option.

This commit fixes or refactor following:

Ref: 7519ee3c8c79691bf2612a3b5d4b8756bd05458d

rbikar commented 1 year ago

run tests

rbikar commented 1 year ago

run tests

rbikar commented 1 year ago

run tests

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (7519ee3) 96.89% compared to head (0c06a20) 96.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #212 +/- ## ========================================== - Coverage 96.89% 96.88% -0.01% ========================================== Files 8 8 Lines 998 996 -2 ========================================== - Hits 967 965 -2 Misses 31 31 ``` | [Impacted Files](https://app.codecov.io/gh/release-engineering/ubi-population-tool/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering) | Coverage Δ | | |---|---|---| | [ubipop/cli.py](https://app.codecov.io/gh/release-engineering/ubi-population-tool/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL2NsaS5weQ==) | `95.91% <ø> (ø)` | | | [ubipop/\_\_init\_\_.py](https://app.codecov.io/gh/release-engineering/ubi-population-tool/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL19faW5pdF9fLnB5) | `93.92% <100.00%> (ø)` | | | [ubipop/\_pulp\_client.py](https://app.codecov.io/gh/release-engineering/ubi-population-tool/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL19wdWxwX2NsaWVudC5weQ==) | `96.99% <100.00%> (-0.05%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rbikar commented 1 year ago

run tests

rbikar commented 1 year ago

run tests

rbikar commented 1 year ago

run tests

rbikar commented 1 year ago

run tests