codecov[bot]
commented
1 year ago Codecov Report
All modified lines are covered by tests :white_check_mark:
Comparison is base (
88fba27) 96.89% compared to head (9571b26) 96.89%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #217 +/- ## ======================================= Coverage 96.89% 96.89% ======================================= Files 8 8 Lines 997 997 ======================================= Hits 966 966 Misses 31 31 ``` | [Files](https://app.codecov.io/gh/release-engineering/ubi-population-tool/pull/217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering) | Coverage Δ | | |---|---|---| | [ubipop/\_cdn.py](https://app.codecov.io/gh/release-engineering/ubi-population-tool/pull/217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL19jZG4ucHk=) | `98.74% <100.00%> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
rbikar
Previously the TTL extraction was implemented in such way that it could potentially extract the wrong value, if the URL path contained a component that also matched the regex. This commit changes the re.match() to re.search(), which ensures it will find the first occurrence of the match. It also changes whitelist_externals to allowlist_externals in tox.ini