release-engineering / ubi-population-tool

A tool for populating UBI repositories.
GNU General Public License v3.0
3 stars 14 forks source link

Fix setting verify for requests #219

Closed rbikar closed 10 months ago

rbikar commented 10 months ago

Due to bug https://github.com/psf/requests/issues/3829, setting 'verify' on session doesn't work if REQUESTS_CA_BUNDLE is set on environment. The bundle defined via REQUESTS_CA_BUNDLE will take precedence and the custom bundle provided via 'verify' is ignored.

Let's now set 'verify' for each request.

This can be revetrted when the bug is fixed, likely in python-requests-v3.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c7c2bd0) 96.89% compared to head (d0d0535) 96.89%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #219 +/- ## ======================================= Coverage 96.89% 96.89% ======================================= Files 8 8 Lines 997 998 +1 ======================================= + Hits 966 967 +1 Misses 31 31 ``` | [Files](https://app.codecov.io/gh/release-engineering/ubi-population-tool/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering) | Coverage Δ | | |---|---|---| | [ubipop/\_cdn.py](https://app.codecov.io/gh/release-engineering/ubi-population-tool/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=release-engineering#diff-dWJpcG9wL19jZG4ucHk=) | `98.75% <100.00%> (+<0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.