release-engineering / ubi-population-tool

A tool for populating UBI repositories.
GNU General Public License v3.0
3 stars 14 forks source link

clean-up: remove dead code, format touched files [RHELDST-141] #222

Closed negillett closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.85%. Comparing base (6da04bf) to head (4f57951).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #222 +/- ## ========================================== + Coverage 96.96% 98.85% +1.88% ========================================== Files 8 8 Lines 990 960 -30 ========================================== - Hits 960 949 -11 + Misses 30 11 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

negillett commented 6 months ago

Had to add a couple tests to cover what was touched

negillett commented 6 months ago

Idk what's going on with this Jenkins CI check, not seeing any movement on Jenkins itself nor any way to trigger it here (no access to settings).

rbikar commented 6 months ago

@negillett On the first sight I was a bit worried if the code you removed is really dead, but it seems like there you're right and for some reason we kept a lot of dead code during latest development.

Will try to run integration tests via Jenkins, but currently it is not really reliable.

rbikar commented 6 months ago

run tests

negillett commented 6 months ago

Thanks, @rbikar!

rbikar commented 6 months ago

run tests