Closed negillett closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.72%. Comparing base (
d939d59
) to head (2a785de
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@release-engineering/ubipop @rbikar ptal
run tests
@negillett
I guess with this change released we will need to do a slight change in installation procedure, do you think you can look at that as well? We likely need to change it only in installation in ubipop jobs on jenkins.
seems like integration test failed on installation as well, can you check that as well? This change cannot be merged without those fixes prepared.
@rbikar, yeah, thanks. Looks like poetry just needs to be installed in the installation jobs (including integration test)
Should install poetry
be included in container-images ubi container files or somewhere in distribution-jenkins-csb?
cc @drepelov, maybe you have some insight on the above question?
cc @drepelov, maybe you have some insight on the above question? Well, I would say that in the
ubi-population-jobs.yaml
indistributon-jenkins-csb
repo, the installation of poetry should be added just before the ubi-population-tool installation. For the integration tests, I think it could be enough to just addpip install poetry
as a first command intox.ini
commands_pre
part.
Ah, right, population template is under chron
. Thank you, @drepelov.
run tests
run tests
run tests
run tests
@rbikar, integration tests are failing due to connection error. Should we open a separate ticket to resolve that?
@rbikar, @drepelov, I hadn't considered package build and release using poetry but should be addressed now. Locked dependencies should be included in the package installed via pip from PyPI.
run tests
I don't expect integration tests to pass, as they haven't been passing for a while now due to connection timeout. Installation in the integration tests, however, is using poetry and is successful.
@negillett \
integration tests are failing due to connection error. Should we open a separate ticket to resolve that?\
Yes, please open a ticket.
@negillett \
integration tests are failing due to connection error. Should we open a separate ticket to resolve that?\
Yes, please open a ticket.
This commit replaces setup.py and requirements files with pyproject.toml and implements poetry for dependency management in CI.