release-engineering / ubi-population-tool

A tool for populating UBI repositories.
GNU General Public License v3.0
3 stars 14 forks source link

Migrate to pyproject.toml and poetry [RHELDST-15226] #231

Closed negillett closed 4 months ago

negillett commented 5 months ago

This commit replaces setup.py and requirements files with pyproject.toml and implements poetry for dependency management in CI.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.72%. Comparing base (d939d59) to head (2a785de).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #231 +/- ## ======================================= Coverage 98.72% 98.72% ======================================= Files 7 7 Lines 863 863 ======================================= Hits 852 852 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

negillett commented 5 months ago

@release-engineering/ubipop @rbikar ptal

rbikar commented 4 months ago

run tests

rbikar commented 4 months ago

@negillett

I guess with this change released we will need to do a slight change in installation procedure, do you think you can look at that as well? We likely need to change it only in installation in ubipop jobs on jenkins.

rbikar commented 4 months ago

seems like integration test failed on installation as well, can you check that as well? This change cannot be merged without those fixes prepared.

negillett commented 4 months ago

@rbikar, yeah, thanks. Looks like poetry just needs to be installed in the installation jobs (including integration test) Should install poetry be included in container-images ubi container files or somewhere in distribution-jenkins-csb?

negillett commented 4 months ago

cc @drepelov, maybe you have some insight on the above question?

drepelov commented 4 months ago

cc @drepelov, maybe you have some insight on the above question? Well, I would say that in the ubi-population-jobs.yaml in distributon-jenkins-csb repo, the installation of poetry should be added just before the ubi-population-tool installation. For the integration tests, I think it could be enough to just add pip install poetry as a first command in tox.ini commands_pre part.

negillett commented 4 months ago

Ah, right, population template is under chron. Thank you, @drepelov.

negillett commented 4 months ago

awaiting https://gitlab.cee.redhat.com/exd-guild-distribution/distribution-jenkins-csb/-/merge_requests/415

negillett commented 4 months ago

run tests

negillett commented 4 months ago

run tests

negillett commented 4 months ago

run tests

negillett commented 4 months ago

run tests

negillett commented 4 months ago

@rbikar, integration tests are failing due to connection error. Should we open a separate ticket to resolve that?

negillett commented 4 months ago

@rbikar, @drepelov, I hadn't considered package build and release using poetry but should be addressed now. Locked dependencies should be included in the package installed via pip from PyPI.

negillett commented 4 months ago

run tests

negillett commented 4 months ago

I don't expect integration tests to pass, as they haven't been passing for a while now due to connection timeout. Installation in the integration tests, however, is using poetry and is successful.

rbikar commented 4 months ago

@negillett \

integration tests are failing due to connection error. Should we open a separate ticket to resolve that?\

Yes, please open a ticket.

negillett commented 4 months ago

@negillett \

integration tests are failing due to connection error. Should we open a separate ticket to resolve that?\

Yes, please open a ticket.

created https://issues.redhat.com/browse/RHELDST-25075