Source rpm of modules package not in whitelist cannot be handled

emilyzheng commented 5 years ago

There's httpd modulemd which has profiles:

    "profiles" : {
        "default" : [ 
            "httpd-tools"
        ]
    }

When package httpd-tools included in modulemd is in packages whitelist:

packages:
  include:
  - httpd-tools.*
modules:
  include:
  - name: httpd
    stream: 2.4
    profiles:
    - default

Population log is as below ('sourcerpm' of httpd-tools-2.4.6-88.el7.x86_64.rpm is httpd-2.4.6-88.el7.src.rpm):

2019-04-12 02:49:21 +0000 [WARNING ] Package httpd-tools doesn't reference its source rpm
...
2019-04-12 02:49:21 +0000 [INFO    ] Would associate httpd-tools-2.4.6-88.el7.x86_64.rpm from rhel-7-server-rpms__7Server__x86_64 to ubi-7-server-rpms__7Server__x86_64
2019-04-12 02:49:21 +0000 [INFO    ] Would associate httpd-tools-2.4.6-88.el7.x86_64.rpm from rhel-7-server-rpms__7Server__x86_64 to ubi-7-server-rpms__7Server__x86_64
2019-04-12 02:49:21 +0000 [INFO    ] Would associate httpd-2.4.6-88.el7.src.rpm from rhel-7-server-source-rpms__7Server__x86_64 to ubi-7-server-source-rpms__7Server__x86_64

Issues:

httpd-tools-2.4.6-88.el7.x86_64.rpm is associated twice because it's counted from both whitelist and modulemd.
Packages counted from modulemd don't have their source rpms searched, so there's warning 'Package httpd-tools doesn't reference its source rpm'. And their source rpms won't be handled at all if they are not in package whitelist.

midnightercz commented 5 years ago

for 1) isn't that captured also in https://github.com/release-engineering/ubi-population-tool/issues/74 ? Can we then reduce scope of this issue just to 2) ?

rbikar commented 5 years ago

This issue was partially fixed: Source rpms of modular pkgs were fixed in #91 Issue with duplicated associations is probably still valid but I think that it's connected to #94

release-engineering / ubi-population-tool

Source rpm of modules package not in whitelist cannot be handled #52