Closed NullVoxPopuli closed 10 months ago
Hmmm. Seems like we should make using workspace:
"just work" (IOW, we shouldn't require an opt-in).
Can you create a test here that emulates the repo structure?
, we shouldn't require an opt-in
Fwiw, the way glimmer-vm is setup now is that release it isn't used at all for releasing, but we use it for everything else it does. We have a gh workflow that'll release when a tag occurs
I think we probably need two things:
npm publish
here) -- pnpm publish
is required to support these workspace:
prefixesworkspace:
and preserve it properly (but it should still update the version part)PR for #1 here: https://github.com/release-it-plugins/workspaces/pull/111
Any progress? I have used this PR in the pnpm workspace project and feel good so far ❤️
I was trying to publish glimmer-vm, and ran in to an issue, noted here: https://github.com/release-it-plugins/workspaces/pull/79#issuecomment-1760589158
I believe this is a reasonable way to move forward with
pnpm
+ "workspace protocol" support, as its opt-in, and existing behavior is unchanged.lemme know what you think, thanks!