search

release-it-plugins / workspaces

A release-it plugin for publishing projects with workspaces
MIT License
62 stars 14 forks source link

inactionable warning #47

Closed hjdivad closed 1 year ago

hjdivad commented 4 years ago 
WARNING @eslint-plugin-graphql-fragment-import/example: Skip publish (package is private)

I understand the cases where this warning provides value, but for me this warning is telling me "WARNING: doing the thing you asked" which is not actionable.

Is there a good way to silence this warning? It seems my best option right now is to duplicate my list of workspaces by specifying them in both package.json:.workspaces as well as package.json:.release-it.plugins.release-it-yarn-workspaces.workspaces but this seems potentially error-prone to me.

Thoughts on a config to opt-out of this warning?

rwjblue commented 4 years ago

It seems my best option right now is to duplicate my list of workspaces by specifying them in both package.json:.workspaces as well as package.json:.release-it.plugins.release-it-yarn-workspaces.workspaces but this seems potentially error-prone to me.

Ya, there are cases where you need to duplicate the config (that is why I added those options), but IMHO this case should not need it.

I think we should remove the warning (and move it to a debugging log instead), but I do think we need to work a bit more on progress indicators (https://github.com/rwjblue/release-it-yarn-workspaces/issues/31).