search

release-it-plugins / workspaces

A release-it plugin for publishing projects with workspaces
MIT License
62 stars 14 forks source link

supports scoped registry names #65

Closed hnrchrdl closed 2 years ago

hnrchrdl commented 3 years ago

addresses #64

smiley-uriux commented 2 years ago

would love to see this get merged!

scalvert commented 2 years ago

@hnrchrdl can you rebase with master? If you do that it'll trigger the checks to be run again, which have been updated/adjusted in a separate PR.

hnrchrdl commented 2 years ago

can you rebase with master? If you do that it'll trigger the checks to be run again, which have been updated/adjusted in a separate PR.

@scalvert rebase is done

hnrchrdl commented 2 years ago

tests are failing after rebase, i found changes from this commit being culprit https://github.com/release-it-plugins/release-it-yarn-workspaces/commit/0cf96f4850a3da83d8f9fbe0ffe7b3e7b48b5b7a

hnrchrdl commented 2 years ago

i now set the test env for jest to node, but still errors from the tests. not sure how much deeper i really want to dive here.

scalvert commented 2 years ago

@hnrchrdl if you give me permissions to push to your fork, I can update this PR. I have a local branch that's working.

hnrchrdl commented 2 years ago

@scalvert sorry, not possible, because the fork belongs to the org i am working for. could you instead open a PR on the fork's feature branch? otherwise feel free to cherry-pick my commits however you like.

scalvert commented 2 years ago

Got it. Makes sense. I'll likely just push your branch to a local one in this repo and re-open the PR. I'm just in the process of renaming the repo and republishing the package, so I'll get to that once this is complete.

hnrchrdl commented 2 years ago

another rebase followed by snapshot updates fixed tests again.

scalvert commented 2 years ago

@hnrchrdl thanks for working on this!

scalvert commented 2 years ago

Released in https://github.com/release-it-plugins/workspaces/releases/tag/v3.1.0