relevance / blue-ridge

Framework for JavaScript Testing (currently a Rails Plugin)
http://groups.google.com/group/blueridgejs
MIT License
480 stars 40 forks source link

loadInlineScript disabled? #24

Open 198d opened 15 years ago

198d commented 15 years ago

Specs running on the command line under env.js don't execute inline tags in the fixture body. Even if this is supposed to be the default behavior, there should be a way to re-enable inline script loading without modifying test_runner.js. We monkey-patched to fix this issue just by commenting out line 57 in test_runner.js ("loadInlineScript: function(){},").

Looks like there was a recent commit that changed the way test_runner is loading fixtures ( http://github.com/relevance/blue-ridge/commit/7617cd85fb71e5cfe0e6e54d9d8f5281e31079ea ). Just wondering what the rationale behind that particular change was...

karnowski commented 14 years ago

Hmm, I had just turned that feature off because it was conflicting in some of my tests. I hadn't thought that some folks might be relying on it. You have a great point, though, that this should be configurable. I'm marking this ticket as a feature request for a config option. Thanks!