Spec files with syntax errors do not fail command-line builds

relevance / blue-ridge

Framework for JavaScript Testing (currently a Rails Plugin)

http://groups.google.com/group/blueridgejs

MIT License

480 stars 40 forks source link

Spec files with syntax errors do not fail command-line builds #8

Closed karnowski closed 15 years ago

karnowski commented 15 years ago

If a spec file has a failing test, it'll fail when ran from the command-line. But if it has an in-your-face flat-out wrong JavaScript syntax error, Rhino spits out an error to stderr but does not report a failure. The overall build reports success.

The problem here is that Rhino's "load()" function swallows JavaScript exceptions due to syntax errors. We'll have to patch Rhino or more likely write a different Java load function that correctly reports errors.

karnowski commented 15 years ago

Can't duplicate this using Blue Ridge. (I'm seeing it quite a bit in the env.js qunit test suite, but for some reason Blue Ridge appears immune.) Marking as won't fix and closing.