search

relferreira / metabase-sparksql-databricks-driver

GNU Affero General Public License v3.0
31 stars 32 forks source link

Match on lower case database-type #10

Closed bjgbeelen closed 1 year ago

bjgbeelen commented 1 year ago

Apparently some Databricks backend implementations return capital database-types

Converting the input database-type to lowercase before running the re-matches does the trick in getting the appropriate type for me.

It would be great if you could accept this fix for this driver. However, I do think the better solution would be to fix it in the Metabase maintained SparkSQL driver eventually. I'll open up a PR there too

Cheers!

bjgbeelen commented 1 year ago

This fixes #7

relferreira commented 1 year ago

Thank you for the fix @bjgbeelen. I couldn't reproduce the error, but it seems ok to merge this change