Closed gayanhewa closed 7 years ago
Here we need to update language files for all three languages
@thinkholic we can merge this in and have to first complete the translations for each page on the site for Sinhala. Once completed we can use them as a template to add the rest easily. And we can do it in parallel.
With the flat ui theme we have right now this will probably break the main navigation to a second line
@gayanhewa Yes. agreed.
@thilinag any fixes?
I am going get this PR to a separate branch so we can get contributes easily before merging.
Made it a dropdown. We are adding English as well yes? This way It wont take much space in the menu. Still running out of space in tamil lang. Need to shorten the phone numbers link. Possible to reword it? @yoosuf
Good job @thilinag
@thilinag according to last image with drop down, who do Sinhala and English users know that drop down is to select language?
@danishka This is a common pattern.
If this is too confusing we can try a second tier navigation bar above the primary nav.
Tamil header Sinhala header
Fix tamil header css
@thilinag ok agreed machan!
Shall we release English and Sinhala for now?
@naveenmadhawa for this @yoosuf shortened the අත්යවශ්ය දුරකථන අංක in tamil. Fixed in the google sheet
we can remove මුල් පිටුව link also right ? since the logo is going to the homepage.
I am going to rebase the and resolve these conflicts. I merged @thilinag PR to my branch so check if everything is up to date
All- I am working on adding eng support.
See #177
@gayanhewa I merged this into dev
.
What you've done
Implement the Multi-Language support for the site.
Why have you done it
Support additional languages.
Screenshot (if visual)
Any testing carried out
Manual
Next steps
In order to get this fully completed, we need some support on getting the translations complete. Once all the keys have been created under
resources/lang/si
we can then replicate the file underresources/lang/ta
and commit the Tamil translations and uncomment the language toggle for Tamil.