reliefsupports / reliefsupports.org-v1

Relief Supports is an open source project to support volunteers who working in relief activities.
http://reliefsupports.org
MIT License
57 stars 63 forks source link

Adding multi-language support for the UI #158

Closed gayanhewa closed 7 years ago

gayanhewa commented 7 years ago

What you've done

Implement the Multi-Language support for the site.

Why have you done it

Support additional languages.

Screenshot (if visual)

multi

Any testing carried out

Manual

Next steps

In order to get this fully completed, we need some support on getting the translations complete. Once all the keys have been created under resources/lang/si we can then replicate the file under resources/lang/ta and commit the Tamil translations and uncomment the language toggle for Tamil.

heimdallrj commented 7 years ago

Here we need to update language files for all three languages

gayanhewa commented 7 years ago

@thinkholic we can merge this in and have to first complete the translations for each page on the site for Sinhala. Once completed we can use them as a template to add the rest easily. And we can do it in parallel.

thilinag commented 7 years ago

With the flat ui theme we have right now this will probably break the main navigation to a second line

heimdallrj commented 7 years ago

@gayanhewa Yes. agreed.

@thilinag any fixes?

heimdallrj commented 7 years ago

I am going get this PR to a separate branch so we can get contributes easily before merging.

thilinag commented 7 years ago

Made it a dropdown. We are adding English as well yes? This way It wont take much space in the menu. Still running out of space in tamil lang. Need to shorten the phone numbers link. Possible to reword it? @yoosuf

screenshot_2017-06-02_19-19-54

screenshot_2017-06-02_20-23-24

yoosuf commented 7 years ago

Good job @thilinag

danishka commented 7 years ago

@thilinag according to last image with drop down, who do Sinhala and English users know that drop down is to select language?

thilinag commented 7 years ago

@danishka This is a common pattern.

screenshot_2017-06-02_23-30-04

screenshot_2017-06-02_23-44-24

screenshot_2017-06-02_23-49-11

If this is too confusing we can try a second tier navigation bar above the primary nav.

naveenmadhawa commented 7 years ago

Tamil header tamil Sinhala header sinhala

Fix tamil header css

danishka commented 7 years ago

@thilinag ok agreed machan!

danishka commented 7 years ago
  1. EN, TA, SI won't understand by everyone. lets make it foolproof
  2. if Sinhala is by default, what if a tamil user visit the page? or someone can not read either sinhala or tamil.
danishka commented 7 years ago

Shall we release English and Sinhala for now?

thilinag commented 7 years ago

@naveenmadhawa for this @yoosuf shortened the අත්‍යවශ්‍ය දුරකථන අංක in tamil. Fixed in the google sheet

thilinag commented 7 years ago

we can remove මුල් පිටුව link also right ? since the logo is going to the homepage.

gayanhewa commented 7 years ago

I am going to rebase the and resolve these conflicts. I merged @thilinag PR to my branch so check if everything is up to date

heimdallrj commented 7 years ago

All- I am working on adding eng support.

heimdallrj commented 7 years ago

See #177

heimdallrj commented 7 years ago

@gayanhewa I merged this into dev.