search

reliefsupports / reliefsupports.org-v1

Relief Supports is an open source project to support volunteers who working in relief activities.
http://reliefsupports.org
MIT License
57 stars 63 forks source link

IdeaBiz SMS Gateway Intergration #190

Open ravithb opened 7 years ago

ravithb commented 7 years ago

What you've done

... Creating an endpoint (POST /sms/receive) to receive sms in the format documented in http://docs.ideabiz.lk/APIs/SMS

Why have you done it

... As a partial fix for issue https://github.com/reliefsupports/reliefsupports.org/issues/8

Any testing carried out

... Manual testing was carried out.

image

gayanhewa commented 7 years ago

@ravithb good stuff. A couple of questions, is it possible to pull in the Ideabiz SMS classes trough composer without polluting the global app namespace? Worst case publish and pull in your own package. And move the business logic that is relevant to the app to the app src.

ravithb commented 7 years ago

@gayan thanks. I'll check and get the idea biz classes through composer. Its the first time I'm working on laravel and composer, so its good that you pointed it out. :)

On 7 June 2017 at 19:15, Gayan notifications@github.com wrote:

@ravithb https://github.com/ravithb good stuff. A couple of questions, is it possible to pull in the Ideabiz SMS classes trough composer without polluting the global app namespace? Worst case publish and pull in your own package. And move the business logic that is relevant to the app to the app src.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reliefsupports/reliefsupports.org/pull/190#issuecomment-306799401, or mute the thread https://github.com/notifications/unsubscribe-auth/AGcJgFzz1dmVjFeyUGv38DeZI57V3moqks5sBqmNgaJpZM4NyhDc .

heimdallrj commented 7 years ago

@ravithb are you working on those changes as @gayanhewa mentioned? Should we keep the PR without merging until you finish those or?

Plus, I changed the base to dev and alos the issue title.. please check and correct it if it's not represet what you did. thanks!

ravithb commented 7 years ago

@thinkholic Yes, I'll work on those today, we can keep the PR open till those are done. You are right, the base should be dev.

ravithb commented 7 years ago

@gayanhewa @thinkholic please review commits 3a5f8bd and ffa0c51. Thanks.

gayanhewa commented 7 years ago

@ravithb stash the commits to one. Can you also add a link to the ideabiz package repo

ravithb commented 7 years ago

I had to restructure the original ideabiz code. https://github.com/ravithb/IdeaBiz-Request-Handler---PHP

ravithb commented 7 years ago

@gayanhewa pls see 53df6c1

heimdallrj commented 7 years ago

@ravithb @gayanhewa Will take this tonight.

danishka commented 6 years ago

@thinkholic Can you merge this pr?