Popups on schedules map

religious-ecologies / omeka-s-theme

1 stars 1 forks source link

Popups on schedules map #52

Closed lmullen closed 3 years ago

lmullen commented 3 years ago

Should they receive any special styles?

lmullen commented 3 years ago

[x] Jim will make the links from the map popups open a new tab
[x] Kim will look at the styles for the popups/labels

lmullen commented 3 years ago

@kimisgold I think this one is close. I like the new styles. I'd suggest two things:

[x] Can the popup be just a bit wider? For some denominations, it breaks to two lines.
[x] Maybe slightly fewer schedules can be returned for each county? It can result in some tall popups.

To illustrate both of those.

kimisgold commented 3 years ago

I think these might fall within @jimsafley's purview. He has a better understanding of how these popups are populated, and he probably knows where to change the leaflet option for the default popup width.

kimisgold commented 3 years ago

The popups are now fixed to be 400px in width and show the first 10 schedule results.

IdaAkiwumi commented 3 years ago

@kimisgold Is it possible for the full popups to display within the viewable area (as much as possible) and not necessarily above the selected city? This is what happens when I select Weld, Colorado. I have to keep pressing zoom out to see the full box. So maybe the arrow can be to the side or below the selected city and the box itself can adjust based on the rotation of the arrow?

kimisgold commented 3 years ago

I think this is starting to get beyond the initial scope of the issue, which primarily concerns the styling for the popups. I'll open an issue on https://github.com/religious-ecologies/Mare-module since that handles the map functionality.

@lmullen Do the latest changes resolve the issue?

lmullen commented 3 years ago

I agree that there is more we can do to improve style and functionality of this map. But for now, we just wanted to have a good, workable first version. I like @kimisgold's idea of calling this done for now, and opening an issue on the Mare-module repo to gather remaining ideas.