search

relinc / SurePulse

SurePulse is a desktop application for processing sensor data from a Split Hopkinson Pressure Bar (SHPB)
http://www.relinc.net/software
10 stars 2 forks source link

Ragged Data Import #112

Closed markhalonen closed 3 years ago

markhalonen commented 3 years ago

Will not import ragged data anymore but there is no warning or explanation. I just fails to import

Waiting on data file

markhalonen commented 3 years ago

@jotaivalkoski can you try to track this down? Luke found a ragged file that doesn't give popup but he's keeping it a secret

An example would be 

time,voltage 1, voltage 2
1,3,4
2,3.1,4.1
3,2.3,5.6
,3.4,3.4
markhalonen commented 3 years ago

This is how I tried to fix it before: https://github.com/relinc/SurePulse/issues/82

So maybe just trying to build a unit test that fails is a good first step

jotaivalkoski commented 3 years ago

do we want to add an error function for ragged data?

markhalonen commented 3 years ago

it should show a dialog saying "Please fix your data" and not do anything else