relinc / SurePulseDataProcessor

Part of the Sure-Pulse software package. This software processes material property data like stress and strain.
GNU General Public License v3.0
2 stars 1 forks source link

#24 Citations #29

Closed markhalonen closed 6 years ago

markhalonen commented 6 years ago

For some reason I named the branch references. Will need to fetch the references branch on Processor, Viewer, and SPLibraries to test.

bhalonen commented 6 years ago

Going to figure out how to fetch branches and test today.

bhalonen commented 6 years ago

Mark, you should rebase or pull from main before making a pull request. I've needed to rebase a couple of times to fix the build. (Same path thing)

bhalonen commented 6 years ago

Did you merge in all of your changes? I'm not seeing the "showCitationDialog" in your commit...

    [javac] C:\Users\brent\git\SurePulseDataProcessor\build\build\src\net\relinc\processor\controllers\SplashPageController.java:201: error: cannot find symbol
    [javac]         Dialogs.showCitationDialog();
    [javac]                ^
    [javac]   symbol:   method showCitationDialog()
    [javac]   location: class Dialogs
    [javac] Note: C:\Users\brent\git\SurePulseDataProcessor\build\build\src\net\relinc\processor\controllers\EditCell.java uses unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
markhalonen commented 6 years ago

That's here in the SPLibraries repo. So you'll have to fetch the references branch there

bhalonen commented 6 years ago

Add a plain-text citation.

bhalonen commented 6 years ago

REL Inc. SURE-Pulse. https://github.com/relinc/SurePulseDataProcessor, 2015.

Change it to just REL Inc. as well.

markhalonen commented 6 years ago

I've added the requested changes