search

relipmoc / skewer

MIT License
95 stars 17 forks source link

Restrict overmatching MACH ifdef to only trigger on OSX and Mach #55

Open Zopolis4 opened 1 year ago

Zopolis4 commented 1 year ago

Hurd also uses Mach, but does not have the same shortcomings as OSX in this area. https://www.gnu.org/software/hurd/hurd/porting/guidelines.html

#ifdef __MACH__
Some applications put Apple Darwin-specific code inside #ifdef __MACH__ guards. Such guard is clearly not enough, since not only Apple uses Mach as a kernel. This should be replaced by #if defined(__MACH__) && defined(__APPLE__)