search

rellermeyer / course_os

CS 439 course OS
BSD 3-Clause "New" or "Revised" License
38 stars 26 forks source link

Cleanup #82

Closed ValentijnvdBeek closed 3 years ago

ValentijnvdBeek commented 3 years ago

This a fairly simple commit which removes some of the junk from the git tree, mainly the outdated userland which doesn't do anything and outdated scheduler source code files. It does contain an idea for writing a syscall method in the kernel space that I didn't fully flesh out, so that should be either be fixed or cherry picked out.

fayalalebrun commented 3 years ago

Looks good, any idea why the tests don't terminate? Seems to be a problem in multiprocessing as well

nasko25 commented 3 years ago

It looks good to me as well, but I get a page fault, when I run it. We probably need to address this issue at some point.

nasko25 commented 3 years ago

The tests don't terminate, because debug_run() is called in start.c. I propose we call test_main() instead of debug_run() so that the tests are actually executed in the CI.

ValentijnvdBeek commented 3 years ago

It looks good to me as well, but I get a page fault, when I run it. We probably need to address this issue at some point.

yeah, that is the badly implemented syscall thing that should either be rewritten or cut out

I propose we call test_main() instead of debug_run() so that the tests are actually executed in the CI.

That is done in the testing framework branch, but yeah, you are right