reloxx13 / Sonoff-Tasmota-Modified

Provide ESP8266 based itead Sonoff with Web, MQTT and OTA firmware using Arduino IDE
GNU General Public License v3.0
26 stars 6 forks source link

#define MOD_VERSION_STRING "mod-1.35.3" #3

Open mike2nl opened 5 years ago

mike2nl commented 5 years ago

Have you look for this feature in other issues and in the wiki? -> yes

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. -> About your comment in sonoff.ino

define MOD_VERSION_STRING "mod-1.35.3" // Would be great to have a macro that fills this from VERSION ...

Describe the solution you'd like A clear and concise description of what you want to happen. -> in the xdrv_02_webserver,ino search for: --> String func = FPSTR(HTTP_SCRIPT_INFO_BEGIN); .. .. --> func += F(D_PROGRAM_VERSION "}2"); func += my_version;

Then add a new line: --> func += F("}1" D_PROGRAM_VERSION "}2"); func += MOD_VERSION_STRING;

It can be done also as if:

ifdef MOD_VERSION_STRING

func += F("}1" D_PROGRAM_VERSION "}2"); func += MOD_VERSION_STRING;

endif

D_PROGRAM_VERSION_MOD has to be added to all the language files. This fix is for the web page only.

When it is needed in status 0 in json format then we have to add some parts in the json creation. For that i must search a little bit more in all the snprintf calls for json. That's then the define for

define D_JSON_VERSION "Version" in the file i18n.h

Here a screenshot and yes i forgot the next line command and it's the idea behind it:

information mod version

And here the corrected one and the name can be like 'Modded Version' or something else: information mod version corrected

reloxx13 commented 5 years ago

This looks difrent to me, also if you like just make pull requests instead of writing so much :D grafik

Your hints are very nice! Also it would be better to post those on the official Tasmota Repo, if it gets denied we can add it here, thats why i made this "mod".

Its rather a collection of some changes which got denied and also to provide latest dev builds.

reloxx13 commented 5 years ago

this is upcoming: grafik

mike2nl commented 5 years ago

@reloxx13 Ahh, i see what you mean about that's comming. No issue at all because i can change that for the test.

About your second posting to message that directly to tasmota.

1st: tasmota is a very good peace os software/firmware and i'm really happy that some people are working on it! Otherwise i would never work together with the Yeti guys in the meaning of much, much status 0 information and know how transfer. As a early beta tester now for the new pages inside the Yeti app. E.G. to show the sensor values from different sonoff devices.

2nd: I'm not OK with all things in tasmota about my little bit more then 30 years (33) but that's normal and 100% ok. That's how the world is spinning. Under other circumstances as happend some weeks ago i would more then happy to help with my experience. Help is for me more important then a get back. But after i made 2 bug reports i got that kind of answers where nothing stays on. When i will to help and give feedback about my findings and i get childish answers? Sorry that's a no go for me becuase i'm not a beginner and my really very little free time is more worth then childish answers. I have no time for that. It's possible me but that i am.

So i came here to you after i found it and when i read your type of answers... here it is very different.

-> make pull requests instead of writing so much :D I love to write because in the beginning when i was 18 and started with radar technic and later software, all learned by millitary, i had to write a lot of scripts, docs of how to, two real books too and a lot of other stuff. So:D ...