Sprite Viewer - Githubissues

remance / Masendor

Open source educational and historical battle action game, All helps accepted

MIT License

142 stars 31 forks source link

Sprite Viewer #34

Closed coppermouse closed 1 year ago

coppermouse commented 1 year ago

I like your project and thinking about being a contributor for it if that is ok.

So the first thing I wanted to try out was to learn about the sprite system and making a tool in that domain.

This is a Sprite Viewer, far as I understand it lists every troop and leader and you can select one to see all surfaces for that unit.

Everything is done in its own file so it should be safe to merge but I totally respect if your are for some reason not interested in this tool

coppermouse commented 1 year ago

I also forgot to add a altered requirements file. To be able to run this you would also need to install pygame_gui

pip install pygame_gui

remance commented 1 year ago

Well, this is an interesting tool. I will add you as a project collaborator then. Thanks a lot :)

I will have a test as well.

remance commented 1 year ago

By the way I changed a few part of the viewer.py code to make it compatible with the newest game version.

I also can't seem to make requirement pygame-gui so I just put the library inside the viewer folder.

2 suggestions that I have for the tool if you have time to implement (I will have a try later if you are ok with me changing the code quite a bit):

The list seem to be ordered in machine listing format (ordered by first character so 100 is put first instead of 1 to 100). I think human readable order (1 to 100 and so on) would be a bit better to explore.
The sprite is a bit cluster at the moment, I am not sure how feasible with pygame-gui, sprite spacing with scrolling system like in the name list would probably help.

remance commented 1 year ago

Also about the contribution, there seem to be an error with your account configuration (likely that you need to validate your email address for the account) that make it so your name not showing up on Github contribution.

coppermouse commented 1 year ago

About being a collaborator, what are the rules? I can push anything as long as I do it in my own branch? Do you have a document for this?

The tool is mostly an experiment. It can be a lot better. I wanted to look into how to make the loading time faster and these sprite generations takes long time. Now when I have a tool for this I can easily test the method.

I am thinking about do a cache for every unit to make the load time faster.

I will add more stuff to my account to see it helps. It could be that I do not have my email in my commits also.