search

remap-keys / remap

Keymap Customization Web app for your keyboard.
https://remap-keys.app
Other
227 stars 27 forks source link

Empty user name #713

Closed otahinosame closed 2 years ago

otahinosame commented 2 years ago

My user name is not displayed on the screen for saving and sharing keymaps. When I Save and Share, my user name shows null.

4A2B27E3-7782-4193-8490-91147B903341

FD9FDDF2-40A7-4CB4-AD83-06C1CEA4E13F

yoichiro commented 2 years ago

@otahinosame I have fixed this issue by changing the logic like the following:

  1. If user.displayName is not null, use it.
  2. If user.providerData[n].displayName is not null, use it.
  3. If user.email is not null, use its user name part.
  4. Otherwise, use "(no name)".
otahinosame commented 2 years ago

@yoichiro Thank you. I tried sharing a keymap and it worked well.

yoichiro commented 2 years ago

@otahinosame Great! Thank you for the feedback.