search

remap-keys / remap

Keymap Customization Web app for your keyboard.
https://remap-keys.app
Other
227 stars 27 forks source link

Encoder support for KeyboardModel and some classes #734

Closed yoichiro closed 2 years ago

yoichiro commented 2 years ago

Related #201

This pull request adds a new feature to support encoders for KeyboardModel and some other classes. For instance, if some keys have an encoder ID in the VIA JSON file, the KeyboardModel object provides whether the key has an encoder ID or not.

yoichiro commented 2 years ago

@adamrocker Could you review this pull request? I would like to confirm whether this approach looks good to your idea or not.

adamrocker commented 2 years ago

Your approach looks perfect. I agree with this.

adamrocker commented 2 years ago

LGTM, thanks!