Keyboard registration should not require PRODUCT in config.h.

remap-keys / remap

Keymap Customization Web app for your keyboard.

https://remap-keys.app

Other

224 stars 27 forks source link

Keyboard registration should not require PRODUCT in config.h. #754

Closed takai closed 1 year ago

takai commented 1 year ago

When registering a keyboard to Remap, the registration was rejected because "the product name does not match the actual PRODUCT value in the config.h file".

But QMK has recently moved their configuration to info.json; PRODUCT is no longer defined in config.h.

Please see below for details on the QMK changes: https://github.com/qmk/qmk_firmware/blob/master/docs/data_driven_config.md

yoichiro commented 1 year ago

@takai We know that currently the PRODUCT is written in the info.json file. When we reviewed your applications, the product names you filled in to the application form were not matched to the keyboard_name values in the info.json files, therefore we rejected your applications.