remarkjs / react-markdown

Markdown component for React
https://remarkjs.github.io/react-markdown/
MIT License
12.4k stars 847 forks source link

React-markdown isn't rendering phone number links anymore #829

Closed aligreene closed 1 week ago

aligreene commented 2 weeks ago

Initial checklist

Affected packages and versions

react-markdown v9.0.0

Link to runnable example

https://codesandbox.io/p/devbox/react-markdown-telephone-link-bug-3vsqry

Steps to reproduce

We recently updated from react-markdown ^8.0.3 to ^9.0.0 and since then, any phone link renders with no value in the link href.

See sandbox for runnable example, or follow steps below:

  1. Create a markdown telephone link e.g.: [123 456 789](tel:123456789)
  2. Check the output.

Expected behavior

The link is rendered in HTML with a href value: <a href="tel:123456789">123 456 789</a>

Actual behavior

The link renders without a href value: <a href="">123 456 789</a>

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

wooorm commented 1 week ago

See the changelog on how to pass a URL transform https://github.com/remarkjs/react-markdown/blob/main/changelog.md#add-urltransform.

github-actions[bot] commented 1 week ago

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

aligreene commented 1 week ago

Thanks very much