remarkjs / react-markdown

Markdown component for React
https://remarkjs.github.io/react-markdown/
MIT License
13.29k stars 876 forks source link

Fixing `string[]` scenario #855

Closed jonathandewitt-dev closed 2 months ago

jonathandewitt-dev commented 3 months ago

Initial checklist

Description of changes

This addresses issue #854 by adding support for string[] in addition to string children.

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2245c64) to head (517bb29). Report is 10 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #855 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 3 3 Lines 1354 1410 +56 Branches 113 115 +2 ========================================= + Hits 1354 1410 +56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

remcohaszing commented 3 months ago

I think this only adds ambiguity. We can better make it clear that we only accept a string. If you have an array of strings you want to join together using newlines, you can write that in your own code.

wooorm commented 3 months ago

Thanks but lets first discuss the issue more: https://github.com/remarkjs/react-markdown/issues/854.

ChristianMurphy commented 2 months ago

resolved at https://github.com/remarkjs/react-markdown/issues/854#issuecomment-2337579770

github-actions[bot] commented 2 months ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.