remarkjs / remark-directive

remark plugin to support directives
https://remark.js.org
MIT License
269 stars 17 forks source link

Trailing whitespace is removed #16

Closed christianvoigt closed 6 months ago

christianvoigt commented 6 months ago

Initial checklist

Affected packages and versions

remark-directive 3.0.0

Link to runnable example

example

Steps to reproduce

I am using remark-directives to mark up deleted and inserted text ranges within paragraphs (similar to critic markup). I use :del[old text ] and :ins[new text ] for this.

Currently, remark-directive does not respect empty spaces around the text. I saw https://github.com/remarkjs/remark-directive/issues/1 but think my case is slightly different as I use normal Markdown inside of the directive that should not be affected by putting it inside a directive. I don't see code fences as a viable workaround in this case.

Expected behavior

The trailing whitespace should be preserved.

Actual behavior

The trailing whitespace is removed.

Runtime

Node v17

Package manager

npm 8

OS

macOS

Build and bundle tools

Webpack

wooorm commented 6 months ago

Hi!

Duplicate of micromark/micromark-extension-directive#22

github-actions[bot] commented 6 months ago

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

github-actions[bot] commented 6 months ago

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks, — bb

github-actions[bot] commented 6 months ago

Hi team! It seems this post is a duplicate, but hasn’t been marked as such. Please post a comment w/ Duplicate of #123(no final .) to do so. See GH docs for more info.

Thanks, — bb